[Flow202][web][skip-ci] [4/x] Extract definition of FetchRevisionsForEntryPayload
ClosedPublic
Actions

Authored by ashoat on Nov 8 2023, 11:32 AM.

Details

Reviewers

tomek

Commits

rCOMM6e069d385b82: [Flow202][web][skip-ci] [4/x] Extract definition of…

Summary

This is actually a lib change, but it helps since we need this type for a typehint to address a Flow error in the new version.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9769

Test Plan

Confirm no changes in Flow error count

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 8 2023, 11:32 AM

Herald added a subscriber: will. · View Herald TranscriptNov 8 2023, 11:32 AM

ashoat added a child revision: D9771: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors.Nov 8 2023, 11:33 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:43 AM

Harbormaster failed remote builds in B23918: Diff 32956!

ashoat requested review of this revision.Nov 8 2023, 11:45 AM

tomek accepted this revision.Nov 9 2023, 2:51 AM

This revision is now accepted and ready to land.Nov 9 2023, 2:51 AM

ashoat retitled this revision from [Flow202][web] [4/x] Extract definition of FetchRevisionsForEntryPayload to [Flow202][web][skip-ci] [4/x] Extract definition of FetchRevisionsForEntryPayload.Nov 19 2023, 5:01 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMM6e069d385b82: [Flow202][web][skip-ci] [4/x] Extract definition of… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM6e069d385b82: [Flow202][web][skip-ci] [4/x] Extract definition of….