Page MenuHomePhabricator

[Flow202][web][skip-ci] [18/x] Fix Flow issues in AddUsersList
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:42 AM.
Tags
None
Referenced Files
F3374269: D9784.id32970.diff
Tue, Nov 26, 2:44 PM
Unknown Object (File)
Sun, Oct 27, 9:02 PM
Unknown Object (File)
Oct 19 2024, 2:39 AM
Unknown Object (File)
Oct 19 2024, 2:39 AM
Unknown Object (File)
Oct 19 2024, 2:38 AM
Unknown Object (File)
Oct 19 2024, 2:33 AM
Unknown Object (File)
Sep 17 2024, 2:25 PM
Unknown Object (File)
Sep 11 2024, 6:49 PM
Subscribers

Details

Summary

The new version of Flow does not want us to lookup undefined in a Map whose keys are not typed to include void. To avoid doing this, I check the key before looking it up.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9783

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 12:08 PM
Harbormaster failed remote builds in B23932: Diff 32970!
This revision is now accepted and ready to land.Nov 9 2023, 3:14 AM
ashoat retitled this revision from [Flow202][web] [18/x] Fix Flow issues in AddUsersList to [Flow202][web][skip-ci] [18/x] Fix Flow issues in AddUsersList.Nov 19 2023, 5:04 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM
This revision was automatically updated to reflect the committed changes.