Differential D9852 Authored by ashoat on Nov 13 2023, 2:47 PM.
Details Summary The new version of Flow caught a type error here! It was introduced in D8706; more details in my comment there. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9851 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptNov 13 2023, 2:47 PM2023-11-13 14:47:10 (UTC-8) Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 2:57 PM2023-11-13 14:57:41 (UTC-8) This revision is now accepted and ready to land.Nov 14 2023, 6:21 AM2023-11-14 06:21:41 (UTC-8) ashoat retitled this revision from [Flow202][keyserver] [4/x] Address type error in rescindPushNotifs to [Flow202][keyserver][skip-ci] [4/x] Address type error in rescindPushNotifs.Nov 19 2023, 5:05 PM2023-11-19 17:05:43 (UTC-8) This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM2023-11-27 15:26:48 (UTC-8) Closed by commit rCOMM7c44b4abb233: [Flow202][keyserver][skip-ci] [4/x] Address type error in rescindPushNotifs (authored by ashoat). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33166 |