[Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 3:26 PM.

Details

Reviewers

tomek

Commits

rCOMMcaa001751b16: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors

Summary

The new version of Flow wants more annotations for function and member definitions. This diff adds all of the required annotations to the keyserver codebase necessary to clear all missing-local-annot errors. This is the keyserver equivalent of D9771 (web) and D9697 (lib).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9872

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24424
Build 210123: arc lint + arc unit

Event Timeline

ashoat created this revision.Nov 13 2023, 3:26 PM

ashoat added a child revision: D9874: [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos.

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:46 PM

Harbormaster failed remote builds in B24090: Diff 33189!

ashoat requested review of this revision.Nov 14 2023, 6:20 AM

tomek accepted this revision.Nov 14 2023, 8:54 AM

tomek added inline comments.

keyserver/src/socket/socket.js
827 ↗	(On Diff #33189)	Depending on how often we use it, we can consider introducing a generic type for debounce to our utils

This revision is now accepted and ready to land.Nov 14 2023, 8:54 AM

ashoat added inline comments.Nov 14 2023, 10:00 AM

keyserver/src/socket/socket.js
827 ↗	(On Diff #33189)	While we import it from four files, this is the only file we'll need to type it this way (including `{ +cancel: () => void }`). There's one other place we use `cancel`, but it's from a React functional component, and Flow is able to deduce the type correctly from our `lodash` libdef

ashoat retitled this revision from [Flow202][keyserver] [24/x] Address missing-local-annot type errors to [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors.Nov 19 2023, 5:11 PM

Rebase

Harbormaster completed remote builds in B24424: Diff 33627.Nov 26 2023, 11:23 PM

ashoat mentioned this in D10015: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.Nov 27 2023, 12:50 AM

Rebase

Harbormaster completed remote builds in B24549: Diff 33781.Nov 27 2023, 2:11 PM

Closed by commit rCOMMcaa001751b16: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors (authored by ashoat). · Explain WhyNov 27 2023, 3:27 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcaa001751b16: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors.

ashoat mentioned this in rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.