Page MenuHomePhabricator

[Flow202][native][skip-ci] [14/x] Fix Flow issues with useDispatch / useSelector being underconstrained
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:33 AM.
Tags
None
Referenced Files
F3374615: D9998.id.diff
Tue, Nov 26, 4:25 PM
Unknown Object (File)
Sat, Nov 23, 6:54 PM
Unknown Object (File)
Fri, Nov 22, 7:05 PM
Unknown Object (File)
Fri, Nov 8, 2:35 AM
Unknown Object (File)
Fri, Nov 8, 1:07 AM
Unknown Object (File)
Tue, Nov 5, 9:19 AM
Unknown Object (File)
Oct 27 2024, 5:32 PM
Unknown Object (File)
Oct 7 2024, 9:48 AM
Subscribers

Details

Summary

This is the native equivalent of D9767. The new version of Flow is requiring function calls to provide explicit type params when Flow isn't able to infer them.

While Flow isn't able to infer types from the generic useSelector in react-redux, our version of it has explicit types, and doesn't have that issue.

This diff migrates all of the errant imports of react-redux's useSelector to use ours. It also switches useDispatch to the one introduced in D9694.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9997

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24439
Build 210155: arc lint + arc unit