Page MenuHomePhabricator

[Flow202][native][skip-ci] [19/x] Remove unused guardedSetState function in DeleteThread
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:36 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 1:13 PM
Unknown Object (File)
Wed, Nov 6, 8:41 AM
Unknown Object (File)
Wed, Nov 6, 8:41 AM
Unknown Object (File)
Wed, Nov 6, 8:41 AM
Unknown Object (File)
Wed, Nov 6, 8:41 AM
Unknown Object (File)
Sep 28 2024, 9:30 PM
Unknown Object (File)
Sep 14 2024, 11:16 PM
Unknown Object (File)
Sep 8 2024, 11:13 PM
Subscribers

Details

Summary

We removed the last usage in D6103, but didn't remove the function itself. The new version of Flow wanted me to add typehints, but instead I'm just going to delete the function since it's not used.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10002

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24444
Build 210160: arc lint + arc unit