Page MenuHomePhabricator

[Flow202][native][skip-ci] [27/x] Fix Flow issues with TOGGLE_PIN redux-persist migration
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:48 AM.
Tags
None
Referenced Files
F3386339: D10011.id.diff
Fri, Nov 29, 4:16 AM
Unknown Object (File)
Tue, Nov 26, 9:06 AM
Unknown Object (File)
Wed, Nov 6, 7:17 AM
Unknown Object (File)
Oct 17 2024, 11:12 AM
Unknown Object (File)
Oct 17 2024, 11:12 AM
Unknown Object (File)
Oct 17 2024, 11:11 AM
Unknown Object (File)
Oct 17 2024, 11:11 AM
Unknown Object (File)
Oct 15 2024, 5:46 PM
Subscribers

Details

Summary

Separating this out because I had to make some more significant changes.

The new version of Flow isn't able to interpret that filtering on RawMessageInfo.type will result in an array with a different type param.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10010

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24452
Build 210168: arc lint + arc unit