Page MenuHomePhabricator

[Flow202][native][skip-ci] [47/x] Parameterize StyleSheet.flatten invocations
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:25 AM.
Tags
None
Referenced Files
F3178516: D10031.diff
Fri, Nov 8, 2:06 AM
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Sun, Nov 3, 2:35 PM
Unknown Object (File)
Thu, Oct 17, 11:50 AM
Unknown Object (File)
Thu, Oct 17, 11:50 AM
Unknown Object (File)
Thu, Oct 17, 11:49 AM
Unknown Object (File)
Thu, Oct 17, 11:49 AM
Unknown Object (File)
Sep 6 2024, 1:46 AM
Subscribers

Details

Summary

Separating this out because I made some opinionated changes in Markdown. I don't think we need to import FlattenedTextStyle anymore because Flow is able to deduce the types automatically based on the type param.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10030

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24473
Build 210204: arc lint + arc unit