Differential D10046 Authored by ashoat on Nov 27 2023, 1:32 AM.
Details Summary This diff will be reverted after the React Native 0.72 upgrade (tracked in ENG-5892). This diff needs to exist because I'm landing the Flow 0.202 upgrade before the React Native 0.72 upgrade. It appears that Platform.select types are improved in later versions of React Native, and prior to those improvements these typehints are necessary. NOTE: CI will fail on this diff, but only temporarily. Once ENG-5893 is resolved, we should expect it to pass.
Depends on D10045 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHarbormaster returned this revision to the author for changes because remote builds failed.Nov 27 2023, 1:44 AM2023-11-27 01:44:07 (UTC-8) Harbormaster failed remote builds in B24490: Diff 33693!Nov 27 2023, 1:55 AM2023-11-27 01:55:54 (UTC-8) This revision is now accepted and ready to land.Nov 27 2023, 7:27 AM2023-11-27 07:27:18 (UTC-8) Harbormaster failed remote builds in B24530: Diff 33748!Nov 27 2023, 9:17 AM2023-11-27 09:17:49 (UTC-8) Harbormaster failed remote builds in B24550: Diff 33782!Nov 27 2023, 2:52 PM2023-11-27 14:52:28 (UTC-8) Harbormaster completed remote builds in B24554: Diff 33786.Nov 27 2023, 3:14 PM2023-11-27 15:14:26 (UTC-8) Closed by commit rCOMM997a4be79c51: [Flow202][native] [62/x] Fill in types for all Platform.select invocations (authored by ashoat). · Explain WhyNov 27 2023, 3:29 PM2023-11-27 15:29:34 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33786 |