Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [23/x] Address type errors in addSessionChangeInfoToResult
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:25 PM.
Tags
None
Referenced Files
F3389065: D9872.id33188.diff
Fri, Nov 29, 5:23 PM
F3388450: D9872.diff
Fri, Nov 29, 2:24 PM
Unknown Object (File)
Tue, Nov 26, 6:35 AM
Unknown Object (File)
Sat, Nov 23, 6:04 PM
Unknown Object (File)
Thu, Nov 21, 10:35 AM
Unknown Object (File)
Sun, Nov 10, 6:58 AM
Unknown Object (File)
Oct 15 2024, 6:43 PM
Unknown Object (File)
Oct 7 2024, 4:56 AM
Subscribers

Details

Summary

The new version of Flow forced me to type the local variable userInfos here, which revealed some errors.

From investigation I found that userInfos is definitely an array when set (here, here, and here).

This issue was never surfaced because it looks like if Object.values is passed an array, it just returns that same array.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9871

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:44 PM
Harbormaster failed remote builds in B24089: Diff 33188!
This revision is now accepted and ready to land.Nov 14 2023, 7:35 AM
ashoat retitled this revision from [Flow202][keyserver] [23/x] Address type errors in addSessionChangeInfoToResult to [Flow202][keyserver][skip-ci] [23/x] Address type errors in addSessionChangeInfoToResult.Nov 19 2023, 5:10 PM