[Flow202][native][skip-ci] [32/x] Fix type errors in OverlayNavigator
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 12:50 AM.

Details

Reviewers

tomek

Commits

rCOMM717b76b3d326: [Flow202][native][skip-ci] [32/x] Fix type errors in OverlayNavigator

Summary

Separating this out because it requires exporting some types, introducing some new ones, and a non-types change in one place.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10015

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24457
Build 210173: arc lint + arc unit

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 12:50 AM

ashoat created this revision.

Harbormaster completed remote builds in B24457: Diff 33660.Nov 27 2023, 12:50 AM

ashoat added inline comments.Nov 27 2023, 12:52 AM

native/navigation/overlay-navigator.react.js
164	I had to add this check because `route.params` isn't parameterized here. React Navigation types don't really consider a scenario where a particular navigator requires its screens to have particular `params`