Page MenuHomePhabricator

[Flow202][native][skip-ci] [42/x] Move ImageSource types to native/types/react-native.js and use it to parameterize ref
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:22 AM.
Tags
None
Referenced Files
F3349762: D10026.diff
Fri, Nov 22, 7:02 PM
Unknown Object (File)
Fri, Nov 8, 7:08 AM
Unknown Object (File)
Fri, Nov 8, 5:53 AM
Unknown Object (File)
Fri, Nov 8, 1:44 AM
Unknown Object (File)
Wed, Nov 6, 7:17 AM
Unknown Object (File)
Oct 17 2024, 11:50 AM
Unknown Object (File)
Oct 17 2024, 11:50 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Subscribers

Details

Summary

When we need to import a type from a file inside of the react-native package, we have a practice of only specifying the path to that file in one place in our codebase. The internals are subject to change, so it's easier to handle upgrades this way.

This diff dedups the ImageSource imports, and also adds a new usage of ImageSource to parameterize a useRef in EncryptedImage.

Separating this diff out since it affects multiple files.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10025

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24468
Build 210199: arc lint + arc unit