Page MenuHomePhabricator

[Flow202][native][skip-ci] [52/x] Separate results obj instantiation in android-permissions.js
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:27 AM.
Tags
None
Referenced Files
F3178342: D10036.diff
Fri, Nov 8, 1:33 AM
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Thu, Oct 17, 10:41 AM
Unknown Object (File)
Tue, Oct 15, 5:46 PM
Unknown Object (File)
Wed, Oct 9, 12:23 PM
Subscribers

Details

Summary

Flow doesn't like that results sometimes contains booleans and sometimes contains Promise<boolean>s. This diff separates out the declarations so there is no confusion.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10035

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24478
Build 210209: arc lint + arc unit