Differential D9711 Authored by ashoat on Nov 4 2023, 12:05 PM.
Details Summary The new version of Flow seems to want all new Promise instantiations to be parameterized with the promise's type. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9710 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added a subscriber: will. · View Herald TranscriptNov 4 2023, 12:05 PM2023-11-04 12:05:58 (UTC-7) Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:36 PM2023-11-04 12:36:59 (UTC-7) This revision is now accepted and ready to land.Nov 6 2023, 5:08 AM2023-11-06 05:08:30 (UTC-8) ashoat retitled this revision from [Flow202][lib] [19/23] Fix Flow issues in unparameterized Promise constructors to [Flow202][lib][skip-ci] [19/23] Fix Flow issues in unparameterized Promise constructors.Nov 19 2023, 4:54 PM2023-11-19 16:54:37 (UTC-8) This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM2023-11-27 15:25:33 (UTC-8) Closed by commit rCOMM60964238b0a2: [Flow202][lib][skip-ci] [19/23] Fix Flow issues in unparameterized Promise… (authored by ashoat). · Explain Why This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 32715 |