Page MenuHomePhabricator

[Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:38 AM.
Tags
None
Referenced Files
F3178447: D9777.diff
Fri, Nov 8, 1:49 AM
Unknown Object (File)
Sun, Oct 27, 9:13 PM
Unknown Object (File)
Sat, Oct 19, 2:38 AM
Unknown Object (File)
Sat, Oct 19, 2:38 AM
Unknown Object (File)
Sat, Oct 19, 2:38 AM
Unknown Object (File)
Sat, Oct 19, 2:38 AM
Unknown Object (File)
Sat, Oct 19, 2:33 AM
Unknown Object (File)
Oct 8 2024, 6:14 AM
Subscribers

Details

Summary

Flow was printing errors because it was having trouble deducing the types for these selectors. Adding typehints solved the errors.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9776

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24543
Build 211025: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:55 AM
Harbormaster failed remote builds in B23925: Diff 32963!
This revision is now accepted and ready to land.Nov 9 2023, 3:09 AM
ashoat retitled this revision from [Flow202][web] [11/x] Fix Flow issues in selectors to [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors.Nov 19 2023, 5:02 PM