[Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues
ClosedPublic
Actions

Authored by ashoat on Nov 4 2023, 12:00 PM.

Details

Reviewers

atul

Commits

rCOMMcd42b5ecb574: [Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues

Summary

The new version of Flow supports BigInt, so we can get rid of these.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9700

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 4 2023, 12:00 PM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 4 2023, 12:00 PM

ashoat added a child revision: D9702: [Flow202][lib][skip-ci] [10/23] Fix Flow issues with untyped let declarations in entry-reducer.Nov 4 2023, 12:01 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:19 PM

Harbormaster failed remote builds in B23743: Diff 32705!

ashoat requested review of this revision.Nov 4 2023, 12:21 PM

Thanks for clearing these

This revision is now accepted and ready to land.Nov 5 2023, 10:48 AM

ashoat retitled this revision from [Flow202][lib] [9/23] Get rid of BigInt $FlowIssues to [Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues.Nov 19 2023, 11:46 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMMcd42b5ecb574: [Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcd42b5ecb574: [Flow202][lib][skip-ci] [9/23] Get rid of BigInt $FlowIssues.