[Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs
ClosedPublic
Actions

Authored by ashoat on Nov 7 2023, 6:56 AM.

Details

Reviewers

inka

Commits

rCOMM62a5c69b274d: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed…

Summary

It's hard since you're not running the new Flow, but going forward would appreciate if you could try to make sure to type all collections in all diffs to avoid introducing new work for me.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9721

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 7 2023, 6:56 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 7 2023, 6:56 AM

ashoat added a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.Nov 7 2023, 7:00 AM

ashoat edited parent revisions, added: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js; removed: D9721: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.Nov 7 2023, 7:01 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 7 2023, 7:07 AM

Harbormaster failed remote builds in B23864: Diff 32892!

ashoat requested review of this revision.Nov 7 2023, 7:16 AM

Sure, I'll try to do that

This revision is now accepted and ready to land.Nov 7 2023, 7:35 AM

There's actually a lot more I have to do here after the most recently landed diffs

ashoat removed a parent revision: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.Nov 7 2023, 10:39 AM

ashoat removed a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.Nov 7 2023, 10:41 AM

Updated to cover all diffs landed to master. Didn't end up being that hard actually

This revision is now accepted and ready to land.Nov 7 2023, 10:41 AM

ashoat added a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.

ashoat added inline comments.Nov 7 2023, 10:45 AM

lib/actions/device-actions.js
31 ↗	(On Diff #32915)	This is actually a type error because `DeviceTokenUpdateRequest` has `+deviceToken: string`, but the device token from `DeviceTokens` can be `?string` (nullable). Fixed in D9751
54 ↗	(On Diff #32915)	This is actually a type error because `DeviceTokenUpdateRequest` has `+deviceToken: string`, but the device token from `DeviceTokens` can be `?string` (nullable). Fixed in D9751

Harbormaster failed remote builds in B23882: Diff 32915!Nov 7 2023, 10:53 AM

ashoat removed a parent revision: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.Nov 11 2023, 11:59 AM

ashoat removed a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.

Rebase

ashoat added a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.

Harbormaster failed remote builds in B24019: Diff 33095!Nov 11 2023, 12:10 PM

ashoat removed a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.Nov 19 2023, 4:57 PM

ashoat retitled this revision from [Flow202][lib] [24/23] Fix Flow issues from Inka's recently landed diffs to [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.

ashoat added a parent revision: D9721: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.

ashoat removed a parent revision: D9721: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.

ashoat added a child revision: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMM62a5c69b274d: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM62a5c69b274d: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed….