Page MenuHomePhabricator

[Flow202][lib][skip-ci] [17/23] Fix Flow issues in lib/shared/state-sync
ClosedPublic

Authored by ashoat on Nov 4 2023, 12:05 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Nov 8, 3:39 AM
Unknown Object (File)
Fri, Nov 8, 3:30 AM
Unknown Object (File)
Fri, Nov 8, 2:03 AM
Unknown Object (File)
Mon, Nov 4, 8:12 AM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:33 PM
Subscribers

Details

Summary

Similar to the preceding diff: Flow was printing errors because it was having trouble deducing the types for these selectors.

I extracted the selector definitions into their own variables so I could annotate them with specific types, which cleared the errors.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9708

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:34 PM
Harbormaster failed remote builds in B23751: Diff 32713!
This revision is now accepted and ready to land.Nov 6 2023, 4:58 AM
ashoat retitled this revision from [Flow202][lib] [17/23] Fix Flow issues in lib/shared/state-sync to [Flow202][lib][skip-ci] [17/23] Fix Flow issues in lib/shared/state-sync.Nov 19 2023, 3:04 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.