Page MenuHomePhabricator

[Flow202][native][skip-ci] [1/x] Ignore electron-update-server in native
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 17, 1:10 AM
Unknown Object (File)
Tue, Nov 26, 4:27 PM
Unknown Object (File)
Nov 22 2024, 5:36 PM
Unknown Object (File)
Oct 27 2024, 5:51 PM
Unknown Object (File)
Sep 28 2024, 10:52 PM
Unknown Object (File)
Sep 28 2024, 10:52 PM
Unknown Object (File)
Sep 28 2024, 10:48 PM
Unknown Object (File)
Sep 28 2024, 10:34 PM
Subscribers

Details

Summary

Not sure why the new Flow is seeing this directory while the old did not. However, we've had this problem before, as we can see with native/.flowconfig ignoring a variety of other projects.

(The reason we need this is that the Flow in native doesn't have libdefs set up for eg. Electron.)

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9751

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24426
Build 210142: arc lint + arc unit