Page MenuHomePhabricator
Differential D9991

[Flow202][native][skip-ci] [7/x] Fix leftover this keyword in ChatThreadList hook conversion
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 1, 6:30 PM
Unknown Object (File)
Tue, Apr 1, 8:28 AM
Unknown Object (File)
Sat, Mar 29, 2:01 AM
Unknown Object (File)
Tue, Mar 18, 11:15 AM
Unknown Object (File)
Tue, Mar 18, 11:15 AM
Unknown Object (File)
Tue, Mar 18, 10:59 AM
Unknown Object (File)
Tue, Mar 18, 10:37 AM
Unknown Object (File)
Feb 25 2025, 4:44 PM
View All Files
Subscribers
tomek

Details

Reviewers
atul
Commits
rCOMM7623096b8bd2: [Flow202][native][skip-ci] [7/x] Fix leftover this keyword in ChatThreadList…
Summary

This was accidentally left over in D9171. The new version of Flow picked up the issue.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9990

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24432
Build 210148: arc lint + arc unit

Revision Contents
Changeset List

PathSize
native/
chat/
2 lines

Diff 33635

View Options

native/chat/chat-thread-list.react.js

Show First 20 Lines • Show All 396 Lines • ▼ Show 20 Lines async ensureAndroidPushNotifsEnabled() {
let [hasPermission] = permissionPromisesResult; let [hasPermission] = permissionPromisesResult;
const [, canRequestPermission] = permissionPromisesResult; const [, canRequestPermission] = permissionPromisesResult;
if (!hasPermission && canRequestPermission) { if (!hasPermission && canRequestPermission) {
const permissionResponse = await (async () => { const permissionResponse = await (async () => {
// We issue a call to sleep to match iOS behavior where prompt // We issue a call to sleep to match iOS behavior where prompt
// doesn't appear immediately but after logged-out modal disappears // doesn't appear immediately but after logged-out modal disappears
await sleep(10); await sleep(10);
await this.requestAndroidNotificationsPermission(); return await this.requestAndroidNotificationsPermission();
marcinUnsubmitted
Not Done
Inline Actions

We definitely should return something from this lambda since otherwise it is useless to assign it to variable.

When we find we don't have Android notif permissions, we ignore the result of requestAndroidNotificationsPermission. It seems like that would cause us to fail to register notif permissions on Android.

If we find that we don't have permissions then just calling await this.requestAndroidNotificationsPermission(); would result in a prompt asking for notifications permissions. However if the user grants those permissions then hasPermissions is still falsy (since promise returned nothing), so deviceToken will be set to null. Nevertheless permissions are actually granted byt the OS, so the state on the device and keyserver would heal itself on next render.

This differential fixes this case so that if user grants permissions correct state is achieved immediately without need for additional re-render to heal the state.

marcin: We definitely should return something from this lambda since otherwise it is useless to assign…
})(); })();
hasPermission = permissionResponse; hasPermission = permissionResponse;
} }
if (!hasPermission) { if (!hasPermission) {
this.failedToRegisterPushPermissionsAndroid(!canRequestPermission); this.failedToRegisterPushPermissionsAndroid(!canRequestPermission);
return; return;
} }
▲ Show 20 Lines • Show All 328 Lines • Show Last 20 Lines