Page MenuHomePhabricator
Differential D10025

[Flow202][native][skip-ci] [41/x] Fix type error in native/themes/colors.js
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 1:21 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Mar 20, 2:49 PM
Unknown Object (File)
Wed, Mar 19, 7:18 PM
Unknown Object (File)
Wed, Mar 19, 7:18 PM
Unknown Object (File)
Thu, Mar 13, 4:48 AM
Unknown Object (File)
Tue, Mar 11, 3:59 PM
Unknown Object (File)
Tue, Mar 11, 3:57 PM
Unknown Object (File)
Mar 1 2025, 12:59 PM
Unknown Object (File)
Feb 20 2025, 12:05 PM
View All 78 Files
Subscribers
tomek

Details

Reviewers
ginsu
Commits
rCOMMa9e27da65312: [Flow202][native][skip-ci] [41/x] Fix type error in native/themes/colors.js
Summary

The new Flow was printing this error:

Error ------------------------------------------------------------------------------------------ themes/colors.js:304:10

Cannot return StyleSheet.create(...) because an index signature declaring the expected key / value type is read-only in
Styles [1] but writable in object type [2]. [incompatible-variance]

 [2] 285| ): StyleSheetOf<IS> {
 [1] 286|   const result: Styles = {};
        :
     301|     }
     302|     result[key] = filledInStyle;
     303|   }
     304|   return StyleSheet.create(result);
     305| }
     306|
     307| function styleSelector<IS: Styles>(

Styles actually isn't read-only, but React Native's type for StyleSheet.create limits its type param to be read-only.

I fixed it by making our StyleSheetOf type read-only. However, that exposed more errors where we use typeof unboundStyles, so I had to add $ReadOnlys to all of those.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10024

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24467
Build 210198: arc lint + arc unit

Revision Contents
Changeset List

Diff 33670

View Options

native/account/logged-out-modal.react.js

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/calendar/calendar.react.js

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/calendar/entry.react.js

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/calendar/section-footer.react.js

// @flow // @flow
import { addCommunityActionType } from '../actions/community-actions.js'; import { addCommunityActionType } from '../actions/community-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {
logInActionTypes,
keyserverRegisterActionTypes,
} from '../actions/user-actions.js';
import { import {
communityStoreOpsHandlers, communityStoreOpsHandlers,
type CommunityStoreOperation, type CommunityStoreOperation,
type ReplaceCommunityOperation, type ReplaceCommunityOperation,
type RemoveAllCommunitiesOperation,
} from '../ops/community-store-ops.js'; } from '../ops/community-store-ops.js';
import type { CommunityStore } from '../types/community-types.js'; import type {
CommunityStore,
CommunityInfo,
} from '../types/community-types.js';
import { defaultEnabledApps } from '../types/enabled-apps.js';
import type { BaseAction } from '../types/redux-types'; import type { BaseAction } from '../types/redux-types';
import type { RawThreadInfos } from '../types/thread-types';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers; const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;
export default function reduceCommunityStore( export default function reduceCommunityStore(
state: CommunityStore, state: CommunityStore,
action: BaseAction, action: BaseAction,
newThreadInfos: RawThreadInfos,
): { ): {
communityStore: CommunityStore, communityStore: CommunityStore,
communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>, communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
} { } {
if (action.type === addCommunityActionType) { if (
action.type === logInActionTypes.success ||
action.type === siweAuthActionTypes.success ||
action.type === keyserverRegisterActionTypes.success
) {
kamilUnsubmitted
Not Done
Inline Actions

wondering, shouldn't we also add action.type === fullStateSyncActionType?

kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
ginsuAuthorUnsubmitted
Done
Inline Actions

I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver

ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
kamilUnsubmitted
Not Done
Inline Actions

But based on the code below, communities are computed based on newThreadInfos which are synced - see here (cc. @atul)

I am afraid that on fullStateSyncActionType we will have inconsistency between threads (threadTypeIsCommunityRoot) and communities in this store

kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
const removeAllOpertation: RemoveAllCommunitiesOperation = {
type: 'remove_all_communities',
};
const replaceOperations = Object.keys(newThreadInfos)
.filter(threadID =>
threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
)
.map(threadID => {
const communityInfo: CommunityInfo = {
enabledApps: defaultEnabledApps,
};
return {
type: 'replace_community',
payload: {
id: threadID,
communityInfo,
},
};
});
atulUnsubmitted
Not Done
Inline Actions

You could do something like following:

const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => {
  if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) {
    const communityInfo = {
      enabledApps: defaultEnabledApps,
    };
    acc.push({
      type: 'replace_community',
      payload: {
        id: threadID,
        communityInfo,
      },
    });
  }
  return acc;
}, []);

(generated with ChatGPT)

that lets us avoid an iteration, but probably doesn't make a difference

atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…
const commmunityStoreOperations = [
removeAllOpertation,
...replaceOperations,
];
return {
communityStore: processStoreOps(state, commmunityStoreOperations),
communityStoreOperations: commmunityStoreOperations,
};
} else if (action.type === addCommunityActionType) {
const replaceOperation: ReplaceCommunityOperation = { const replaceOperation: ReplaceCommunityOperation = {
type: 'replace_community', type: 'replace_community',
payload: { payload: {
id: action.payload.id, id: action.payload.id,
communityInfo: { communityInfo: {
...action.payload.newCommunityInfo, ...action.payload.newCommunityInfo,
}, },
}, },
Show All 13 Lines
View Options

native/chat/chat-input-bar.react.js

Loading...
View Options

native/chat/failed-send.react.js

Loading...
View Options

native/chat/message-list-container.react.js

Loading...
View Options

native/chat/message-list-header-title.react.js

Loading...
View Options

native/chat/message-list.react.js

Loading...
View Options

native/chat/settings/color-selector-modal.react.js

Loading...
View Options

native/chat/settings/compose-subchannel-modal.react.js

Loading...
View Options

native/chat/settings/delete-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-color.react.js

Loading...
View Options

native/chat/settings/thread-settings-description.react.js

Loading...
View Options

native/chat/settings/thread-settings-home-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings-leave-thread.react.js

Loading...
View Options

native/chat/settings/thread-settings-list-action.react.js

Loading...
View Options

native/chat/settings/thread-settings-member.react.js

Loading...
View Options

native/chat/settings/thread-settings-name.react.js

Loading...
View Options

native/chat/settings/thread-settings-promote-sidebar.react.js

Loading...
View Options

native/chat/settings/thread-settings-push-notifs.react.js

Loading...
View Options

native/chat/settings/thread-settings.react.js

Loading...
View Options

native/chat/thread-settings-button.react.js

Loading...
View Options

native/components/link-button.react.js

Loading...
View Options

native/components/thread-list-thread.react.js

Loading...
View Options

native/components/thread-list.react.js

Loading...
View Options

native/components/user-list-user.react.js

Loading...
View Options

native/keyboard/keyboard-input-host.react.js

Loading...
View Options

native/media/media-gallery-keyboard.react.js

Loading...
View Options

native/profile/appearance-preferences.react.js

Loading...
View Options

native/profile/custom-server-modal.react.js

Loading...
View Options

native/profile/default-notifications-preferences.react.js

Loading...
View Options

native/profile/dev-tools.react.js

Loading...
View Options

native/profile/edit-password.react.js

Loading...
View Options

native/profile/profile-screen.react.js

Loading...
View Options

native/profile/relationship-list-item.react.js

Loading...
View Options

native/themes/colors.js

Loading...
View Options

native/tooltip/tooltip.react.js

Loading...