Details

Reviewers

Commits

rCOMM5a2049c5ac41: [Flow202][web][skip-ci] [9/x] Fix Flow issues with types being underconstrained

Summary

The new version of Flow is requiring declarations to provide explicit type params when Flow isn't able to infer them. This diff adds those declarations in most cases that aren't specific enough to be covered in another diff.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9774

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24489
Build 210235: arc lint + arc unit

Event Timeline

ashoat created this revision.Nov 8 2023, 11:37 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 8 2023, 11:37 AM

ashoat added a child revision: D9776: [Flow202][web][skip-ci] [10/x] Fix nonsensical use of selectors in ThreadPickerModal.Nov 8 2023, 11:37 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:52 AM

Harbormaster failed remote builds in B23923: Diff 32961!

ashoat requested review of this revision.Nov 8 2023, 11:58 AM

atul accepted this revision.Nov 9 2023, 11:45 AM

This revision is now accepted and ready to land.Nov 9 2023, 11:45 AM

ashoat mentioned this in D9864: [Flow202][keyserver][skip-ci] [15/x] Fix Flow issues with types being underconstrained.Nov 13 2023, 3:19 PM

ashoat retitled this revision from [Flow202][web] [9/x] Fix Flow issues with types being underconstrained to [Flow202][web][skip-ci] [9/x] Fix Flow issues with types being underconstrained.Nov 19 2023, 5:02 PM

Rebase

Harbormaster completed remote builds in B24418: Diff 33621.Nov 26 2023, 10:59 PM

ashoat mentioned this in D10034: [Flow202][native][skip-ci] [50/x] Fix Flow issues with types being underconstrained.Nov 27 2023, 1:26 AM

Prettier fix for last rebase

Harbormaster completed remote builds in B24489: Diff 33692.Nov 27 2023, 1:40 AM

Rebase

Harbormaster completed remote builds in B24542: Diff 33774.Nov 27 2023, 2:06 PM

Closed by commit rCOMM5a2049c5ac41: [Flow202][web][skip-ci] [9/x] Fix Flow issues with types being underconstrained (authored by ashoat). · Explain WhyNov 27 2023, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM5a2049c5ac41: [Flow202][web][skip-ci] [9/x] Fix Flow issues with types being underconstrained.

ashoat mentioned this in rCOMM4a7465727992: [Flow202][keyserver][skip-ci] [15/x] Fix Flow issues with types being….

ashoat mentioned this in rCOMMec0d792cc5bd: [Flow202][native][skip-ci] [50/x] Fix Flow issues with types being….Nov 27 2023, 3:29 PM