[Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors
ClosedPublic
Actions

Authored by ashoat on Nov 8 2023, 11:38 AM.

Details

Reviewers

tomek

Commits

rCOMM81b91112fc76: [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors

Summary

Flow was printing errors because it was having trouble deducing the types for these selectors. Adding typehints solved the errors.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9776

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24543
Build 211025: arc lint + arc unit

Event Timeline

ashoat created this revision.Nov 8 2023, 11:38 AM

Herald added a subscriber: will. · View Herald TranscriptNov 8 2023, 11:38 AM

ashoat added a child revision: D9778: [Flow202][web][skip-ci] [12/x] Fix Flow issues with computed properties.Nov 8 2023, 11:38 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:55 AM

Harbormaster failed remote builds in B23925: Diff 32963!

ashoat requested review of this revision.Nov 8 2023, 11:59 AM

tomek accepted this revision.Nov 9 2023, 3:09 AM

This revision is now accepted and ready to land.Nov 9 2023, 3:09 AM

ashoat retitled this revision from [Flow202][web] [11/x] Fix Flow issues in selectors to [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors.Nov 19 2023, 5:02 PM

ashoat mentioned this in D10035: [Flow202][native][skip-ci] [51/x] Fix Flow issues with computed properties.Nov 27 2023, 1:27 AM

Rebase

Harbormaster completed remote builds in B24543: Diff 33775.Nov 27 2023, 2:06 PM

Closed by commit rCOMM81b91112fc76: [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors (authored by ashoat). · Explain WhyNov 27 2023, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM81b91112fc76: [Flow202][web][skip-ci] [11/x] Fix Flow issues in selectors.

ashoat mentioned this in rCOMM65e680d25944: [Flow202][native][skip-ci] [51/x] Fix Flow issues with computed properties.Nov 27 2023, 3:29 PM