Page MenuHomePhabricator

[Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos
ClosedPublic

Authored by ashoat on Nov 13 2023, 3:26 PM.
Tags
None
Referenced Files
F3388665: D9874.id33555.diff
Fri, Nov 29, 3:31 PM
F3388662: D9874.id33299.diff
Fri, Nov 29, 3:31 PM
Unknown Object (File)
Tue, Nov 26, 3:40 PM
Unknown Object (File)
Tue, Nov 26, 7:02 AM
Unknown Object (File)
Tue, Nov 26, 5:44 AM
Unknown Object (File)
Tue, Nov 26, 5:34 AM
Unknown Object (File)
Tue, Nov 26, 3:51 AM
Unknown Object (File)
Sun, Nov 24, 9:34 AM
Subscribers

Details

Summary

The new version of Flow is detecting an issue here. We can't mutate serverThreadInfos, as it is an immutable collection. Instead we'll need to do some copies.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9873

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:47 PM
Harbormaster failed remote builds in B24091: Diff 33190!
This revision is now accepted and ready to land.Nov 15 2023, 1:24 AM
ashoat retitled this revision from [Flow202][keyserver] [25/x] Fix type error in push notif fetchInfos to [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos.Nov 19 2023, 5:11 PM