Differential D10000 Authored by ashoat on Nov 27 2023, 12:35 AM.
Tags None Referenced Files Subscribers None Tokens "100" token, awarded by atul.
Details Summary This is the native equivalent of D9769. The new version of Flow needs all function parameters to have typehints. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D9999 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHarbormaster completed remote builds in B24441: Diff 33644.Nov 27 2023, 12:35 AM2023-11-27 00:35:23 (UTC-8) ashoat added a child revision: D10001: [Flow202][native][skip-ci] [17/x] Type TextInput onFocus/onBlur. This revision is now accepted and ready to land.Nov 27 2023, 6:42 AM2023-11-27 06:42:02 (UTC-8) Closed by commit rCOMMc4c59eb37be6: [Flow202][native][skip-ci] [16/x] Type React.forwardRef input functions (authored by ashoat). · Explain WhyNov 27 2023, 3:28 PM2023-11-27 15:28:05 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33644 |