Page MenuHomePhabricator

[Flow202][native][skip-ci] [45/x] Add types for uniqueChatMessageInfoItemsMap
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:24 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 1:03 AM
Unknown Object (File)
Thu, Nov 7, 12:57 AM
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Thu, Oct 17, 11:50 AM
Unknown Object (File)
Thu, Oct 17, 11:50 AM
Unknown Object (File)
Thu, Oct 17, 11:49 AM
Unknown Object (File)
Thu, Oct 17, 11:49 AM
Unknown Object (File)
Sep 13 2024, 9:53 PM
Subscribers

Details

Summary

After typing the Map, Flow doesn't like that we're calling get with a value that is nullable. To address this I add an invariant that should never fire since we only show message results that are delivered from the server, which always have id set.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10028

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24471
Build 210202: arc lint + arc unit