[Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase
ClosedPublic
Actions

Authored by ashoat on Nov 5 2023, 8:11 AM.

Details

Reviewers

michal

Commits

rCOMMcfa6724437be: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase

Summary

This one was pretty simple... just added a bunch of types in various places.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Test Plan

Make sure all Flow errors in desktop are resolved

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 5 2023, 8:11 AM

Herald added subscribers: will, tomek. · View Herald TranscriptNov 5 2023, 8:11 AM

ashoat retitled this revision from [Flow202][desktop] Flow issues in desktop codebase to [Flow202][desktop] Fix Flow issues in desktop codebase.Nov 5 2023, 8:12 AM

ashoat edited the summary of this revision. (Show Details)

ashoat added a parent revision: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 5 2023, 8:18 AM

Harbormaster failed remote builds in B23763: Diff 32725!

ashoat requested review of this revision.Nov 5 2023, 8:23 AM

michal accepted this revision.Nov 6 2023, 1:37 AM

This revision is now accepted and ready to land.Nov 6 2023, 1:37 AM

Lint fixes

ashoat added a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 7 2023, 6:56 AM

ashoat removed a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 7 2023, 7:01 AM

ashoat edited parent revisions, added: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs; removed: D9715: [Flow202][lib][skip-ci] [23/23] Fix Flow issues in lib/utils/action-logger.js.

Harbormaster failed remote builds in B23863: Diff 32891!Nov 7 2023, 7:04 AM

ashoat added a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 7 2023, 10:41 AM

ashoat removed a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 7 2023, 10:43 AM

ashoat edited parent revisions, added: D9751: [Flow202][lib][skip-ci] [26/23] Fix type error in DeviceTokenUpdateRequest; removed: D9749: [Flow202][lib][skip-ci] [25/23] Fix Flow issues from Kamil's recently landed diffs.

ashoat added a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 11 2023, 11:59 AM

ashoat removed a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 11 2023, 12:00 PM

ashoat added a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.Nov 19 2023, 4:57 PM

ashoat removed a child revision: D9748: [Flow202][lib][skip-ci] [24/23] Fix Flow issues from Inka's recently landed diffs.

ashoat retitled this revision from [Flow202][desktop] Fix Flow issues in desktop codebase to [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.Nov 19 2023, 4:59 PM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMMcfa6724437be: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMcfa6724437be: [Flow202][desktop][skip-ci] Fix Flow issues in desktop codebase.