[Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions
ClosedPublic
Actions

Authored by ashoat on Nov 8 2023, 11:31 AM.

Details

Reviewers

atul
tomek

Commits

rCOMM8a87ed909f48: [Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions

Summary

The new version of Flow needs all function parameters to have typehints. To type this correctly I looked at the library definition for forwardRef here.

Flow 0.217 introduces a library type for this, but I had to type it manually here.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9768

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 8 2023, 11:31 AM

Herald added a subscriber: will. · View Herald TranscriptNov 8 2023, 11:31 AM

ashoat added a child revision: D9770: [Flow202][web][skip-ci] [4/x] Extract definition of FetchRevisionsForEntryPayload.Nov 8 2023, 11:32 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:42 AM

Harbormaster failed remote builds in B23917: Diff 32955!

ashoat requested review of this revision.Nov 8 2023, 11:45 AM

tomek accepted this revision.Nov 9 2023, 2:51 AM

This revision is now accepted and ready to land.Nov 9 2023, 2:51 AM

ashoat retitled this revision from [Flow202][web] [3/x] Type React.forwardRef input functions to [Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions.Nov 19 2023, 5:01 PM

ashoat mentioned this in D10000: [Flow202][native][skip-ci] [16/x] Type React.forwardRef input functions.Nov 27 2023, 12:35 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:26 PM

Closed by commit rCOMM8a87ed909f48: [Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8a87ed909f48: [Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions.

ashoat mentioned this in rCOMMc4c59eb37be6: [Flow202][native][skip-ci] [16/x] Type React.forwardRef input functions.