Paths

Table of Contentst

Differential D9993

[Flow202][native][skip-ci] [9/x] Type navigation prop on all ReactNav screens
ClosedPublic
Actions

Authored by ashoat on Nov 27 2023, 12:31 AM.

Tags

None

Referenced Files

	F3372794: D9993.diff
	Tue, Nov 26, 7:57 AM

	Unknown Object (File)
	Sat, Nov 23, 11:21 PM

	Unknown Object (File)
	Sat, Nov 23, 5:21 PM

	Unknown Object (File)
	Sat, Nov 23, 12:48 AM

	Unknown Object (File)
	Fri, Nov 8, 2:48 AM

	Unknown Object (File)
	Sun, Oct 27, 5:51 PM

	Unknown Object (File)
	Oct 19 2024, 2:15 AM

	Unknown Object (File)
	Oct 19 2024, 2:15 AM

View All 67 Files

Subscribers

None

Details

Reviewers

ginsu
atul
tomek

Commits

rCOMM34f640c23850: [Flow202][native][skip-ci] [9/x] Type navigation prop on all ReactNav screens

Summary

The new version of Flow wants us to type the navigation prop on all ReactNav screens so it can make sure we're using .Screen components correctly in navigators.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9992

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat requested review of this revision.Nov 27 2023, 12:31 AM

ashoat created this revision.

Harbormaster completed remote builds in B24434: Diff 33637.Nov 27 2023, 12:31 AM

ashoat added a child revision: D9994: [Flow202][native][skip-ci] [10/x] Add type params to ReactNav useNavigationBuilder calls.Nov 27 2023, 12:32 AM

tomek accepted this revision.Nov 27 2023, 3:41 AM

This revision is now accepted and ready to land.Nov 27 2023, 3:41 AM

Closed by commit rCOMM34f640c23850: [Flow202][native][skip-ci] [9/x] Type navigation prop on all ReactNav screens (authored by ashoat). · Explain WhyNov 27 2023, 3:27 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM34f640c23850: [Flow202][native][skip-ci] [9/x] Type navigation prop on all ReactNav screens.

Revision Contents
Changeset List

Path

Size

native/

apps/

apps-directory.react.js

8 lines

profile/

add-keyserver.react.js

8 lines

appearance-preferences.react.js

15 lines

backup-menu.react.js

8 lines

build-info.react.js

8 lines

default-notifications-preferences.react.js

2 lines

delete-account.react.js

8 lines

emoji-user-avatar-creation.react.js

8 lines

keyserver-selection-list.react.js

8 lines

linked-devices.react.js

10 lines

privacy-preferences.react.js

8 lines

relationship-list.react.js

2 lines

secondary-device-qr-code-scanner.react.js

8 lines

tunnelbroker-menu.react.js

8 lines

Diff 33876

native/apps/apps-directory.react.js

Loading...

native/profile/add-keyserver.react.js

Loading...

native/profile/appearance-preferences.react.js

Loading...

native/profile/backup-menu.react.js

Loading...

native/profile/build-info.react.js

Loading...

native/profile/default-notifications-preferences.react.js

Loading...

native/profile/delete-account.react.js

Loading...

native/profile/emoji-user-avatar-creation.react.js

Loading...

native/profile/keyserver-selection-list.react.js

Loading...

native/profile/linked-devices.react.js

Loading...

native/profile/privacy-preferences.react.js

Loading...

native/profile/relationship-list.react.js

Loading...

native/profile/secondary-device-qr-code-scanner.react.js

Loading...

native/profile/tunnelbroker-menu.react.js

Loading...