Page MenuHomePhabricator

[Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers
ClosedPublic

Authored by ashoat on Nov 4 2023, 12:04 PM.
Tags
None
Referenced Files
F3531979: D9707.id32711.diff
Wed, Dec 25, 8:38 AM
F3529695: D9707.diff
Tue, Dec 24, 8:43 PM
Unknown Object (File)
Fri, Dec 20, 1:52 PM
Unknown Object (File)
Mon, Dec 16, 12:50 AM
Unknown Object (File)
Wed, Dec 11, 4:08 AM
Unknown Object (File)
Tue, Dec 10, 9:37 PM
Unknown Object (File)
Mon, Dec 9, 10:02 AM
Unknown Object (File)
Sun, Dec 8, 11:22 AM
Subscribers

Details

Summary

In these cases Flow seems to fear that something might change the value of the secondary condition after it's checked. The errors are cleared after moving the secondary condition into its own branch (in two cases) and assigning the intermediate value before checking it (in one case).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9706

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:30 PM
Harbormaster failed remote builds in B23749: Diff 32711!
This revision is now accepted and ready to land.Nov 5 2023, 11:04 AM
ashoat retitled this revision from [Flow202][lib] [15/23] Fix Flow issues in lib/reducers to [Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers.Nov 19 2023, 3:03 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.