Page MenuHomePhabricator

[Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:31 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 1:43 PM
Unknown Object (File)
Tue, Nov 26, 8:14 AM
Unknown Object (File)
Tue, Nov 26, 4:43 AM
Unknown Object (File)
Mon, Nov 25, 11:20 AM
Unknown Object (File)
Mon, Nov 25, 2:11 AM
Unknown Object (File)
Sun, Nov 24, 7:59 PM
Unknown Object (File)
Sat, Nov 23, 1:48 PM
Unknown Object (File)
Fri, Nov 8, 4:50 AM
Subscribers

Details

Summary

The new version of Flow needs all function parameters to have typehints. To type this correctly I looked at the library definition for forwardRef here.

Flow 0.217 introduces a library type for this, but I had to type it manually here.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9768

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:42 AM
Harbormaster failed remote builds in B23917: Diff 32955!
This revision is now accepted and ready to land.Nov 9 2023, 2:51 AM
ashoat retitled this revision from [Flow202][web] [3/x] Type React.forwardRef input functions to [Flow202][web][skip-ci] [3/x] Type React.forwardRef input functions.Nov 19 2023, 5:01 PM