[Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables that get mutated
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 3:01 PM.

Details

Reviewers

atul

Commits

rCOMMbe075d8192e3: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables…

Summary

This the keyserver counterpart of D9774 (web) and D9706 / D9692 (lib).

There are two main categories of changes here, and both pertain to variables getting mutated:

let declarations where the variable is reassigned later
const declarations of mutable collections that are mutated later

In both of these cases, Flow now wants us to annotate the declaration to cover both the type of the data that's initialized, and also the mutations that later occur.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version o f Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9857

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 13 2023, 3:01 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 13 2023, 3:01 PM

ashoat added a child revision: D9859: [Flow202][keyserver][skip-ci] [10/x] Address type errors with promiseAll / Promise.all.Nov 13 2023, 3:10 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:12 PM

Harbormaster failed remote builds in B24074: Diff 33172!

ashoat added inline comments.Nov 13 2023, 3:14 PM

keyserver/src/push/rescind.js
194–215 ↗	(On Diff #33172)	Oops – this should be in D9859
keyserver/src/updaters/thread-permission-updaters.js
644–646 ↗	(On Diff #33172)	I had to make this change because Flow didn't want me passing `null` to `JSON.parse`. I can probably switch `permissions_from_parent` to `?string` now... I was trying to type it more precisely in the hopes that Flow would be okay with `JSON.parse(null)`. (In my experimentation with V8, `JSON.parse(null)` is okay (and returns `null`) but `JSON.parse(undefined)` is not)
648 ↗	(On Diff #33172)	`null > 0` (and `undefined > 0`) are `true`, but Flow doesn't like us relying on that

Pull out the promises stuff to D9859

ashoat added inline comments.Nov 13 2023, 6:32 PM

keyserver/src/updaters/thread-permission-updaters.js
644–646	I had to make this change because Flow didn't want me passing `null` to `JSON.parse`. I can probably switch `permissions_from_parent` to `?string` now... I was trying to type it more precisely in the hopes that Flow would be okay with `JSON.parse(null)`. (In my experimentation with V8, `JSON.parse(null)` is okay (and returns `null`) but `JSON.parse(undefined)` is not)
648	`null > 0` (and `undefined > 0`) are `true`, but Flow doesn't like us relying on that

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 6:41 PM

Harbormaster failed remote builds in B24093: Diff 33192!

ashoat requested review of this revision.Nov 14 2023, 6:16 AM

Rebase

Harbormaster failed remote builds in B24109: Diff 33209!Nov 14 2023, 6:35 AM

atul accepted this revision.Nov 14 2023, 12:44 PM

This revision is now accepted and ready to land.Nov 14 2023, 12:44 PM

ashoat retitled this revision from [Flow202][keyserver] [9/x] Fix Flow issues with types of variables that get mutated to [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables that get mutated.Nov 19 2023, 5:06 PM

ashoat mentioned this in D10010: [Flow202][native][skip-ci] [26/x] Fix Flow issues with types of variables that get mutated.Nov 27 2023, 12:45 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:27 PM

Closed by commit rCOMMbe075d8192e3: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMbe075d8192e3: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables….

ashoat mentioned this in rCOMM77d36444612a: [Flow202][native][skip-ci] [26/x] Fix Flow issues with types of variables that….