[Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos
ClosedPublic
Actions

Authored by ashoat on Nov 13 2023, 3:26 PM.

Details

Reviewers

Commits

rCOMMf2da8efc541a: [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos

Summary

The new version of Flow is detecting an issue here. We can't mutate serverThreadInfos, as it is an immutable collection. Instead we'll need to do some copies.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9873

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Branch

ashoat/rnupgrade

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Nov 13 2023, 3:26 PM

Herald added a subscriber: tomek. · View Herald TranscriptNov 13 2023, 3:27 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 13 2023, 3:47 PM

Harbormaster failed remote builds in B24091: Diff 33190!

ashoat requested review of this revision.Nov 14 2023, 6:20 AM

Rebase

Harbormaster failed remote builds in B24108: Diff 33208!Nov 14 2023, 6:31 AM

Rebase

Harbormaster failed remote builds in B24112: Diff 33212!Nov 14 2023, 7:09 AM

Rebase

Harbormaster failed remote builds in B24118: Diff 33218!Nov 14 2023, 10:39 AM

marcin accepted this revision.Nov 15 2023, 1:24 AM

This revision is now accepted and ready to land.Nov 15 2023, 1:24 AM

Rebase

Harbormaster failed remote builds in B24151: Diff 33265!Nov 15 2023, 7:02 AM

Rebase

Harbormaster failed remote builds in B24181: Diff 33299!Nov 15 2023, 12:43 PM

ashoat retitled this revision from [Flow202][keyserver] [25/x] Fix type error in push notif fetchInfos to [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos.Nov 19 2023, 5:11 PM

Rebase

Harbormaster completed remote builds in B24264: Diff 33402.Nov 19 2023, 5:39 PM

Rebase

Harbormaster completed remote builds in B24375: Diff 33555.Nov 23 2023, 5:36 AM

Closed by commit rCOMMf2da8efc541a: [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos (authored by ashoat). · Explain WhyNov 27 2023, 3:27 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMMf2da8efc541a: [Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

push/

send.js

7 lines

Diff 33218

View Options

keyserver/src/push/send.js

	// @flow			// @flow

	import { addCommunityActionType } from '../actions/community-actions.js';			import { addCommunityActionType } from '../actions/community-actions.js';
				import { siweAuthActionTypes } from '../actions/siwe-actions.js';
				import {
				logInActionTypes,
				keyserverRegisterActionTypes,
				} from '../actions/user-actions.js';
	import {			import {
	communityStoreOpsHandlers,			communityStoreOpsHandlers,
	type CommunityStoreOperation,			type CommunityStoreOperation,
	type ReplaceCommunityOperation,			type ReplaceCommunityOperation,
				type RemoveAllCommunitiesOperation,
	} from '../ops/community-store-ops.js';			} from '../ops/community-store-ops.js';
	import type { CommunityStore } from '../types/community-types.js';			import type {
				CommunityStore,
				CommunityInfo,
				} from '../types/community-types.js';
				import { defaultEnabledApps } from '../types/enabled-apps.js';
	import type { BaseAction } from '../types/redux-types';			import type { BaseAction } from '../types/redux-types';
				import type { RawThreadInfos } from '../types/thread-types';
				import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';

	const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;			const { processStoreOperations: processStoreOps } = communityStoreOpsHandlers;

	export default function reduceCommunityStore(			export default function reduceCommunityStore(
	state: CommunityStore,			state: CommunityStore,
	action: BaseAction,			action: BaseAction,
				newThreadInfos: RawThreadInfos,
	): {			): {
	communityStore: CommunityStore,			communityStore: CommunityStore,
	communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,			communityStoreOperations: $ReadOnlyArray<CommunityStoreOperation>,
	} {			} {
	if (action.type === addCommunityActionType) {			if (
				action.type === logInActionTypes.success \|\|
				action.type === siweAuthActionTypes.success \|\|
				action.type === keyserverRegisterActionTypes.success
				) {
				kamilUnsubmitted Not Done Inline Actions wondering, shouldn't we also add `action.type === fullStateSyncActionType`? kamil: wondering, shouldn't we also add `action.type === fullStateSyncActionType`?
				ginsuAuthorUnsubmitted Done Inline Actions I spoke to @atul about this and from what I understood we don't need this type since the community store is not synced with the keyserver ginsu: I spoke to @atul about this and from what I understood we don't need this type since the…
				kamilUnsubmitted Not Done Inline Actions But based on the code below, communities are computed based on `newThreadInfos` which are synced - see here (cc. @atul) I am afraid that on `fullStateSyncActionType` we will have inconsistency between threads (`threadTypeIsCommunityRoot`) and communities in this store kamil: But based on the code below, communities are computed based on `newThreadInfos` which are…
				const removeAllOpertation: RemoveAllCommunitiesOperation = {
				type: 'remove_all_communities',
				};

				const replaceOperations = Object.keys(newThreadInfos)
				.filter(threadID =>
				threadTypeIsCommunityRoot(newThreadInfos[threadID].type),
				)
				.map(threadID => {
				const communityInfo: CommunityInfo = {
				enabledApps: defaultEnabledApps,
				};
				return {
				type: 'replace_community',
				payload: {
				id: threadID,
				communityInfo,
				},
				};
				});
				atulUnsubmitted Not Done Inline Actions You could do something like following: const replaceOperations = Object.keys(newThreadInfos).reduce((acc, threadID) => { if (threadTypeIsCommunityRoot(newThreadInfos[threadID].type)) { const communityInfo = { enabledApps: defaultEnabledApps, }; acc.push({ type: 'replace_community', payload: { id: threadID, communityInfo, }, }); } return acc; }, []); (generated with ChatGPT) that lets us avoid an iteration, but probably doesn't make a difference atul: You could do something like following: ```lang=js const replaceOperations = Object.keys…

				const commmunityStoreOperations = [
				removeAllOpertation,
				...replaceOperations,
				];

				return {
				communityStore: processStoreOps(state, commmunityStoreOperations),
				communityStoreOperations: commmunityStoreOperations,
				};
				} else if (action.type === addCommunityActionType) {
	const replaceOperation: ReplaceCommunityOperation = {			const replaceOperation: ReplaceCommunityOperation = {
	type: 'replace_community',			type: 'replace_community',
	payload: {			payload: {
	id: action.payload.id,			id: action.payload.id,
	communityInfo: {			communityInfo: {
	...action.payload.newCommunityInfo,			...action.payload.newCommunityInfo,
	},			},
	},			},
	Show All 13 Lines

[Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfosClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33218

keyserver/src/push/send.js

[Flow202][keyserver][skip-ci] [25/x] Fix type error in push notif fetchInfos
ClosedPublic
Actions

Revision Contents
Changeset List