Page MenuHomePhabricator

[Flow202][lib][skip-ci] [3/23] Fix Flow issues with types being underconstrained
ClosedPublic

Authored by ashoat on Nov 4 2023, 11:55 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:49 PM
Unknown Object (File)
Sun, Oct 27, 10:33 PM
Unknown Object (File)
Sun, Oct 20, 2:28 AM
Subscribers

Details

Summary

The new version of Flow is requiring declarations to provide explicit type params when Flow isn't able to infer them. This diff adds those declarations in most cases that aren't specific enough to be covered in another diff.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9694

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:08 PM
Harbormaster failed remote builds in B23737: Diff 32699!
This revision is now accepted and ready to land.Nov 5 2023, 10:41 AM
ashoat retitled this revision from [Flow202][lib] [3/23] Fix Flow issues with types being underconstrained to [Flow202][lib][skip-ci] [3/23] Fix Flow issues with types being underconstrained.Nov 19 2023, 11:45 AM