Page MenuHomePhabricator

[Flow202][native][skip-ci] [16/x] Type React.forwardRef input functions
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:35 AM.
Tags
None
Referenced Files
F3352597: D10000.id33884.diff
Sat, Nov 23, 6:31 AM
Unknown Object (File)
Wed, Nov 13, 7:52 AM
Unknown Object (File)
Wed, Nov 13, 7:52 AM
Unknown Object (File)
Wed, Nov 13, 7:52 AM
Unknown Object (File)
Wed, Nov 13, 7:52 AM
Unknown Object (File)
Fri, Nov 1, 8:00 AM
Unknown Object (File)
Oct 13 2024, 7:14 PM
Unknown Object (File)
Oct 13 2024, 7:14 PM
Subscribers
None
Tokens
"100" token, awarded by atul.

Details

Summary

This is the native equivalent of D9769. The new version of Flow needs all function parameters to have typehints.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9999

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24441
Build 210157: arc lint + arc unit