[Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run Prettier on flow-typed folders
ClosedPublic
Actions

Authored by ashoat on Nov 5 2023, 6:57 AM.

Details

Reviewers

michal
• jon

Commits

rCOMM9f0564e4c88f: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run…

Summary

Two changes here:

Update .prettierignore to cover all folders named flow-typed instead of individually enumerating each flow-typed folder in the repo.
Revert the Prettier changes to services/electron-update-server/flow-typed/npm/express_v4.17.x.js. This is to make it easier to diff against upstream changes, and to make sure it matches the libdef we have in the keyserver folder.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Test Plan

Revert changes in D6783 and then run yarn prettier --write services/electron-update-server to confirm that they aren't reintroduced

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Nov 5 2023, 6:57 AM

Herald added a reviewer: • jon. · View Herald TranscriptNov 5 2023, 6:57 AM

Herald added subscribers: will, tomek. · View Herald Transcript

ashoat added a child revision: D9717: [Flow202][electron-update-server][skip-ci] [2/3] Use the same flow-typed libdef for express throughout our codebase.Nov 5 2023, 6:58 AM

ashoat edited the summary of this revision. (Show Details)Nov 5 2023, 6:58 AM

ashoat edited the summary of this revision. (Show Details)

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 5 2023, 7:03 AM

Harbormaster failed remote builds in B23758: Diff 32720!

ashoat requested review of this revision.Nov 5 2023, 7:53 AM

ashoat added a parent revision: D9691: [RN72][skip-ci] Update Flow to 0.202.1.Nov 5 2023, 8:13 AM

michal accepted this revision.Nov 6 2023, 1:30 AM

This revision is now accepted and ready to land.Nov 6 2023, 1:30 AM

ashoat retitled this revision from [Flow202][electron-update-server] [1/3] Make sure we don't run Prettier on flow-typed folders to [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run Prettier on flow-typed folders.Nov 19 2023, 11:42 AM

This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM

Closed by commit rCOMM9f0564e4c88f: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM9f0564e4c88f: [Flow202][electron-update-server][skip-ci] [1/3] Make sure we don't run….