Details

Reviewers

Commits

rCOMM8cbe88a6c29d: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors

Summary

The new version of Flow wants more annotations for function and member definitions. This diff adds all of the required annotations to the web codebase necessary to clear all missing-local-annot errors. The lib equivalent of this diff is D9697.

I also included some other changes where I type function params that were yielding other Flow errors (different from missing-local-annot).

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9770

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24417
Build 210116: arc lint + arc unit

Event Timeline

ashoat created this revision.Nov 8 2023, 11:33 AM

Herald added a subscriber: will. · View Herald TranscriptNov 8 2023, 11:33 AM

ashoat added a child revision: D9772: [Flow202][web][skip-ci] [6/x] Address type errors in community drawer code.Nov 8 2023, 11:34 AM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:44 AM

Harbormaster failed remote builds in B23919: Diff 32957!

ashoat requested review of this revision.Nov 8 2023, 11:45 AM

tomek accepted this revision.Nov 9 2023, 3:06 AM

tomek added inline comments.

web/account/traditional-login-form.react.js
50 ↗	(On Diff #32957)	Do we still need this invariant?
web/chat/chat-input-bar.react.js
169 ↗	(On Diff #32957)	According to https://flow.org/en/docs/types/arrays/#toc-array-type-shorthand-syntax There is an alternative to the Array<T> syntax: T[]. This syntax is discouraged and may be deprecated in the future.

This revision is now accepted and ready to land.Nov 9 2023, 3:06 AM

ashoat added inline comments.Nov 9 2023, 4:24 AM

web/account/traditional-login-form.react.js
50 ↗	(On Diff #32957)	Yes – `currentTarget` is typed based on the type param (`HTMLInputElement`), but `target` isn't because for some `SyntheticEvent`s, the `target` can be an element nested within the element where is the listener is attached. This doesn't apply in our case since we're not nesting any elements inside the `<input>` (I suspect we could switch these to `currentTarget`, but I don't have the cycles to test that change across the codebase right now)
web/chat/chat-input-bar.react.js
169 ↗	(On Diff #32957)	Thanks for linking – didn't know that it's discouraged. I tend to avoid it for more complicated types, but I've been using it for simple ones like `string[]`

Replace string[] with Array<string>

Harbormaster failed remote builds in B23952: Diff 33004!Nov 9 2023, 5:38 AM

Rebase

ashoat mentioned this in D9170: [web] Support avatar uploads to blob service.Nov 11 2023, 12:01 PM

Harbormaster failed remote builds in B24020: Diff 33096!Nov 11 2023, 12:11 PM

Rebase

Harbormaster failed remote builds in B24063: Diff 33161!Nov 13 2023, 2:48 PM

ashoat mentioned this in D9873: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors.Nov 13 2023, 3:26 PM

ashoat retitled this revision from [Flow202][web] [5/x] Address missing-local-annot type errors to [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors.Nov 19 2023, 5:01 PM

Rebase

Harbormaster completed remote builds in B24261: Diff 33399.Nov 19 2023, 5:39 PM

Rebase

Harbormaster completed remote builds in B24417: Diff 33620.Nov 26 2023, 10:58 PM

ashoat mentioned this in D10015: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.Nov 27 2023, 12:50 AM

Closed by commit rCOMM8cbe88a6c29d: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors (authored by ashoat). · Explain WhyNov 27 2023, 3:26 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM8cbe88a6c29d: [Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors.

ashoat mentioned this in rCOMMcaa001751b16: [Flow202][keyserver][skip-ci] [24/x] Address missing-local-annot type errors.

ashoat mentioned this in rCOMMdb14a28e300e: [Flow202][native][skip-ci] [31/x] Address missing-local-annot type errors.Nov 27 2023, 3:28 PM

[Flow202][web][skip-ci] [5/x] Address missing-local-annot type errorsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 33620

web/account/siwe-login-form.react.js

web/account/traditional-login-form.react.js

web/app.react.js

web/avatars/avatar-hooks.react.js

web/avatars/edit-thread-avatar-menu.react.js

web/avatars/edit-user-avatar-menu.react.js

web/avatars/emoji-avatar-selection-modal.react.js

web/calendar/calendar.react.js

web/calendar/day.react.js

web/calendar/filter-panel.react.js

web/chat/chat-input-bar.react.js

web/chat/chat-message-list.react.js

web/chat/chat-thread-list-item-menu.react.js

web/chat/chat-thread-list.react.js

web/chat/edit-text-message.react.js

web/chat/failed-send.react.js

web/chat/message-tooltip.react.js

web/chat/multimedia-message.react.js

web/chat/robotext-message.react.js

web/components/button.react.js

web/components/dropdown.react.js

web/components/menu.react.js

web/components/navigation-arrows.react.js

web/components/search.react.js

web/input/input-state-container.react.js

web/input/input-state.js

web/modals/history/history-entry.react.js

web/modals/history/history-modal.react.js

web/modals/search/message-search-modal.react.js

web/modals/threads/gallery/thread-settings-media-gallery.react.js

web/modals/threads/members/add-members-modal.react.js

web/modals/threads/members/member.react.js

web/modals/threads/sidebars/sidebar.react.js

web/modals/threads/subchannels/subchannel.react.js

web/modals/update-modal.react.js

web/push-notif/push-notifs-handler.js

web/redux/focus-handler.react.js

web/redux/initial-state-gate.js

web/redux/persist.js

web/redux/visibility-handler.react.js

web/settings/password-change-modal.js

web/settings/tunnelbroker-test.react.js

web/utils/tooltip-action-utils.js

web/utils/typeahead-utils.js

[Flow202][web][skip-ci] [5/x] Address missing-local-annot type errors
ClosedPublic
Actions

Revision Contents
Changeset List