Page MenuHomePhabricator

[Flow202][native][skip-ci] [44/x] Fix type error in message-search.react.js
ClosedPublic

Authored by ashoat on Nov 27 2023, 1:23 AM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 6, 6:41 AM
Unknown Object (File)
Oct 17 2024, 11:50 AM
Unknown Object (File)
Oct 17 2024, 11:50 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Oct 17 2024, 11:49 AM
Unknown Object (File)
Sep 6 2024, 1:33 PM
Unknown Object (File)
Sep 6 2024, 2:31 AM
Unknown Object (File)
Sep 6 2024, 2:31 AM
Subscribers

Details

Summary

The new version of Flow detected a slight type error here. lastID is nullable, but the type for useSearchMessages requires cursor to be string if specified. We can address this by making cursor nullable as well.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D10027

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24470
Build 210201: arc lint + arc unit