Page MenuHomePhabricator

[Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated
ClosedPublic

Authored by ashoat on Nov 8 2023, 11:36 AM.
Tags
None
Referenced Files
F3370415: D9774.diff
Tue, Nov 26, 2:32 AM
Unknown Object (File)
Mon, Nov 25, 1:54 AM
Unknown Object (File)
Sat, Nov 23, 6:59 PM
Unknown Object (File)
Fri, Nov 8, 4:34 AM
Unknown Object (File)
Wed, Oct 30, 12:51 AM
Unknown Object (File)
Sun, Oct 27, 9:21 PM
Unknown Object (File)
Sun, Oct 27, 9:21 PM
Unknown Object (File)
Sun, Oct 27, 9:21 PM
Subscribers

Details

Summary

This the web counterpart of both D9706 and D9692 (I combined them for web).

There are two main categories of changes here, and both pertain to variables getting mutated:

  1. let declarations where the variable is reassigned later
  2. const declarations of mutable collections that are mutated later

In both of these cases, Flow now wants us to annotate the declaration to cover both the type of the data that's initialized, and also the mutations that later occur.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9773

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 24541
Build 211023: arc lint + arc unit

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 8 2023, 11:50 AM
Harbormaster failed remote builds in B23922: Diff 32960!
This revision is now accepted and ready to land.Nov 9 2023, 11:44 AM

Rebase and fix a new error

ashoat retitled this revision from [Flow202][web] [8/x] Fix Flow issues with types of variables that get mutated to [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated.Nov 19 2023, 5:02 PM