Paths

Table of Contentst

-
lib/
-
media/
3/5
media-utils.js
-
ops/
3/5
report-store-ops.test.js
-
reducers/
3/5
calendar-filters-reducer.js
3/5
message-reducer.js
-
thread-reducer.js
-
selectors/
-
calendar-filter-selectors.js
-
chat-selectors.js
-
user-selectors.js
-
shared/
-
entry-utils.js
-
notif-utils.js
-
radix-tree.js
-
state-sync/
-
entries-state-sync-spec.js
-
threads-state-sync-spec.js
-
users-state-sync-spec.js
-
thread-utils.js
-
socket/
-
activity-handler.react.js
-
socket.react.js
-
utils/
-
drawer-utils.react.js
-
entity-text.js
-
objects.test.js

[Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that get mutated
ClosedPublic
Actions

Authored by ashoat on Nov 4 2023, 12:03 PM.

Details

Reviewers

tomek
bartek
atul

Commits

rCOMM0c7a1b8bc5c3: [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that…

Summary

There are two main categories of changes here, and both pertain to variables getting mutated:

let declarations where the variable is reassigned later
const declarations of mutable collections that are mutated later

In both of these cases, Flow now wants us to annotate the declaration to cover both the type of the data that's initialized, and also the mutations that later occur.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9705

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 24373
Build 209487: arc lint + arc unit

Event Timeline

ashoat created this revision.Nov 4 2023, 12:03 PM

Herald added a subscriber: will. · View Herald TranscriptNov 4 2023, 12:03 PM

ashoat added a child revision: D9707: [Flow202][lib][skip-ci] [15/23] Fix Flow issues in lib/reducers.Nov 4 2023, 12:04 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:28 PM

Harbormaster failed remote builds in B23748: Diff 32710!

ashoat requested review of this revision.Nov 4 2023, 12:31 PM

atul accepted this revision.Nov 5 2023, 11:03 AM

This revision is now accepted and ready to land.Nov 5 2023, 11:03 AM

Rebase

Harbormaster failed remote builds in B23904: Diff 32941!Nov 8 2023, 6:26 AM

ashoat mentioned this in D9774: [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get mutated.Nov 8 2023, 11:36 AM

ashoat mentioned this in D9858: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables that get mutated.Nov 13 2023, 3:01 PM

ashoat mentioned this in D9863: [Flow202][keyserver][skip-ci] [14/x] Address type errors with report-responders.js.Nov 15 2023, 12:18 PM

Rebase

Lint fixes for last rebase

Harbormaster failed remote builds in B24174: Diff 33292!Nov 15 2023, 12:30 PM

Harbormaster failed remote builds in B24178: Diff 33296!Nov 15 2023, 12:38 PM

ashoat retitled this revision from [Flow202][lib] [14/23] Fix Flow issues with types of variables that get mutated to [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that get mutated.Nov 19 2023, 11:48 AM

Rebase

Harbormaster completed remote builds in B24260: Diff 33398.Nov 19 2023, 5:39 PM

Rebase

Harbormaster completed remote builds in B24373: Diff 33553.Nov 23 2023, 5:35 AM

ashoat mentioned this in D10010: [Flow202][native][skip-ci] [26/x] Fix Flow issues with types of variables that get mutated.Nov 27 2023, 12:45 AM

Closed by commit rCOMM0c7a1b8bc5c3: [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that… (authored by ashoat). · Explain WhyNov 27 2023, 3:25 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM0c7a1b8bc5c3: [Flow202][lib][skip-ci] [14/23] Fix Flow issues with types of variables that….

ashoat mentioned this in rCOMM703a41589dda: [Flow202][web][skip-ci] [8/x] Fix Flow issues with types of variables that get….

ashoat mentioned this in rCOMMbe075d8192e3: [Flow202][keyserver][skip-ci] [9/x] Fix Flow issues with types of variables….

ashoat mentioned this in rCOMM77d36444612a: [Flow202][native][skip-ci] [26/x] Fix Flow issues with types of variables that….Nov 27 2023, 3:28 PM

Revision Contents
Changeset List

Path

Size

lib/

media/

media-utils.js

2 lines

ops/

report-store-ops.test.js

7 lines

reducers/

calendar-filters-reducer.js

2 lines

message-reducer.js

10 lines

thread-reducer.js

2 lines

selectors/

calendar-filter-selectors.js

2 lines

chat-selectors.js

8 lines

user-selectors.js

6 lines

shared/

entry-utils.js

2 lines

notif-utils.js

7 lines

radix-tree.js

9 lines

state-sync/

entries-state-sync-spec.js

3 lines

threads-state-sync-spec.js

3 lines

users-state-sync-spec.js

3 lines

thread-utils.js

12 lines

socket/

activity-handler.react.js

7 lines

socket.react.js

2 lines

utils/

drawer-utils.react.js

19 lines

entity-text.js

6 lines

objects.test.js

8 lines

Diff 33553

View Options

lib/media/media-utils.js

// @flow		// @flow

import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';		import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';
import { isSQLiteSupported } from './utils/db-utils.js';		import { isDesktopSafari, isSQLiteSupported } from './utils/db-utils.js';
import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';		import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';
import type { AppState } from '../redux/redux-setup.js';		import type { AppState } from '../redux/redux-setup.js';
import {		import {
workerRequestMessageTypes,		workerRequestMessageTypes,
type WorkerRequestMessage,		type WorkerRequestMessage,
type WorkerResponseMessage,		type WorkerResponseMessage,
} from '../types/worker-types.js';		} from '../types/worker-types.js';

Show All 16 Lines	class DatabaseModule {
status: DatabaseStatus;		status: DatabaseStatus;

constructor() {		constructor() {
const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous		const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous
? undefined		? undefined
: preloadedState.currentUserInfo?.id;		: preloadedState.currentUserInfo?.id;
const isSupported = isSQLiteSupported(currentLoggedInUserID);		const isSupported = isSQLiteSupported(currentLoggedInUserID);

if (!isSupported) {		if (!isSupported \|\| isDesktopSafari()) {
		tomekUnsubmitted Not Done Inline Actions Can we have a const instead of a function that tells if it is Safari? We can avoid having to detect the browser multiple times, as this fact doesn't change through the lifetime of the app. tomek: Can we have a const instead of a function that tells if it is Safari? We can avoid having to…
		kamilAuthorUnsubmitted Done Inline Actions good point, thanks kamil: good point, thanks
this.status = databaseStatuses.notSupported;		this.status = databaseStatuses.notSupported;
		kamilAuthorUnsubmitted Done Inline Actions Naming might be confusing, but at this point database is not supported (we don't have a key to it), it will be supported after main thread will provide encryption key kamil: Naming might be confusing, but at this point database is not supported (we don't have a key to…
		tomekUnsubmitted Not Done Inline Actions Do we change the status later? tomek: Do we change the status later?
		kamilAuthorUnsubmitted Done Inline Actions yes, in `initDBForLoggedInUser()` kamil: yes, in `initDBForLoggedInUser()`
} else {		} else {
this.init();		this.init();
}		}
}		}

init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {		init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {
this.status = databaseStatuses.initInProgress;		this.status = databaseStatuses.initInProgress;
this.worker = new SharedWorker(DATABASE_WORKER_PATH);		this.worker = new SharedWorker(DATABASE_WORKER_PATH);
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines

View Options

lib/ops/report-store-ops.test.js

// @flow		// @flow

import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';		import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';
import { isSQLiteSupported } from './utils/db-utils.js';		import { isDesktopSafari, isSQLiteSupported } from './utils/db-utils.js';
import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';		import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';
import type { AppState } from '../redux/redux-setup.js';		import type { AppState } from '../redux/redux-setup.js';
import {		import {
workerRequestMessageTypes,		workerRequestMessageTypes,
type WorkerRequestMessage,		type WorkerRequestMessage,
type WorkerResponseMessage,		type WorkerResponseMessage,
} from '../types/worker-types.js';		} from '../types/worker-types.js';

Show All 16 Lines	class DatabaseModule {
status: DatabaseStatus;		status: DatabaseStatus;

constructor() {		constructor() {
const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous		const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous
? undefined		? undefined
: preloadedState.currentUserInfo?.id;		: preloadedState.currentUserInfo?.id;
const isSupported = isSQLiteSupported(currentLoggedInUserID);		const isSupported = isSQLiteSupported(currentLoggedInUserID);

if (!isSupported) {		if (!isSupported \|\| isDesktopSafari()) {
		tomekUnsubmitted Not Done Inline Actions Can we have a const instead of a function that tells if it is Safari? We can avoid having to detect the browser multiple times, as this fact doesn't change through the lifetime of the app. tomek: Can we have a const instead of a function that tells if it is Safari? We can avoid having to…
		kamilAuthorUnsubmitted Done Inline Actions good point, thanks kamil: good point, thanks
this.status = databaseStatuses.notSupported;		this.status = databaseStatuses.notSupported;
		kamilAuthorUnsubmitted Done Inline Actions Naming might be confusing, but at this point database is not supported (we don't have a key to it), it will be supported after main thread will provide encryption key kamil: Naming might be confusing, but at this point database is not supported (we don't have a key to…
		tomekUnsubmitted Not Done Inline Actions Do we change the status later? tomek: Do we change the status later?
		kamilAuthorUnsubmitted Done Inline Actions yes, in `initDBForLoggedInUser()` kamil: yes, in `initDBForLoggedInUser()`
} else {		} else {
this.init();		this.init();
}		}
}		}

init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {		init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {
this.status = databaseStatuses.initInProgress;		this.status = databaseStatuses.initInProgress;
this.worker = new SharedWorker(DATABASE_WORKER_PATH);		this.worker = new SharedWorker(DATABASE_WORKER_PATH);
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines

View Options

lib/reducers/calendar-filters-reducer.js

// @flow		// @flow

import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';		import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';
import { isSQLiteSupported } from './utils/db-utils.js';		import { isDesktopSafari, isSQLiteSupported } from './utils/db-utils.js';
import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';		import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';
import type { AppState } from '../redux/redux-setup.js';		import type { AppState } from '../redux/redux-setup.js';
import {		import {
workerRequestMessageTypes,		workerRequestMessageTypes,
type WorkerRequestMessage,		type WorkerRequestMessage,
type WorkerResponseMessage,		type WorkerResponseMessage,
} from '../types/worker-types.js';		} from '../types/worker-types.js';

Show All 16 Lines	class DatabaseModule {
status: DatabaseStatus;		status: DatabaseStatus;

constructor() {		constructor() {
const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous		const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous
? undefined		? undefined
: preloadedState.currentUserInfo?.id;		: preloadedState.currentUserInfo?.id;
const isSupported = isSQLiteSupported(currentLoggedInUserID);		const isSupported = isSQLiteSupported(currentLoggedInUserID);

if (!isSupported) {		if (!isSupported \|\| isDesktopSafari()) {
		tomekUnsubmitted Not Done Inline Actions Can we have a const instead of a function that tells if it is Safari? We can avoid having to detect the browser multiple times, as this fact doesn't change through the lifetime of the app. tomek: Can we have a const instead of a function that tells if it is Safari? We can avoid having to…
		kamilAuthorUnsubmitted Done Inline Actions good point, thanks kamil: good point, thanks
this.status = databaseStatuses.notSupported;		this.status = databaseStatuses.notSupported;
		kamilAuthorUnsubmitted Done Inline Actions Naming might be confusing, but at this point database is not supported (we don't have a key to it), it will be supported after main thread will provide encryption key kamil: Naming might be confusing, but at this point database is not supported (we don't have a key to…
		tomekUnsubmitted Not Done Inline Actions Do we change the status later? tomek: Do we change the status later?
		kamilAuthorUnsubmitted Done Inline Actions yes, in `initDBForLoggedInUser()` kamil: yes, in `initDBForLoggedInUser()`
} else {		} else {
this.init();		this.init();
}		}
}		}

init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {		init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {
this.status = databaseStatuses.initInProgress;		this.status = databaseStatuses.initInProgress;
this.worker = new SharedWorker(DATABASE_WORKER_PATH);		this.worker = new SharedWorker(DATABASE_WORKER_PATH);
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines

View Options

lib/reducers/message-reducer.js

// @flow		// @flow

import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';		import { DATABASE_WORKER_PATH, SQLJS_FILE_PATH } from './utils/constants.js';
import { isSQLiteSupported } from './utils/db-utils.js';		import { isDesktopSafari, isSQLiteSupported } from './utils/db-utils.js';
import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';		import WorkerConnectionProxy from './utils/WorkerConnectionProxy.js';
import type { AppState } from '../redux/redux-setup.js';		import type { AppState } from '../redux/redux-setup.js';
import {		import {
workerRequestMessageTypes,		workerRequestMessageTypes,
type WorkerRequestMessage,		type WorkerRequestMessage,
type WorkerResponseMessage,		type WorkerResponseMessage,
} from '../types/worker-types.js';		} from '../types/worker-types.js';

Show All 16 Lines	class DatabaseModule {
status: DatabaseStatus;		status: DatabaseStatus;

constructor() {		constructor() {
const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous		const currentLoggedInUserID = preloadedState.currentUserInfo?.anonymous
? undefined		? undefined
: preloadedState.currentUserInfo?.id;		: preloadedState.currentUserInfo?.id;
const isSupported = isSQLiteSupported(currentLoggedInUserID);		const isSupported = isSQLiteSupported(currentLoggedInUserID);

if (!isSupported) {		if (!isSupported \|\| isDesktopSafari()) {
		tomekUnsubmitted Not Done Inline Actions Can we have a const instead of a function that tells if it is Safari? We can avoid having to detect the browser multiple times, as this fact doesn't change through the lifetime of the app. tomek: Can we have a const instead of a function that tells if it is Safari? We can avoid having to…
		kamilAuthorUnsubmitted Done Inline Actions good point, thanks kamil: good point, thanks
this.status = databaseStatuses.notSupported;		this.status = databaseStatuses.notSupported;
		kamilAuthorUnsubmitted Done Inline Actions Naming might be confusing, but at this point database is not supported (we don't have a key to it), it will be supported after main thread will provide encryption key kamil: Naming might be confusing, but at this point database is not supported (we don't have a key to…
		tomekUnsubmitted Not Done Inline Actions Do we change the status later? tomek: Do we change the status later?
		kamilAuthorUnsubmitted Done Inline Actions yes, in `initDBForLoggedInUser()` kamil: yes, in `initDBForLoggedInUser()`
} else {		} else {
this.init();		this.init();
}		}
}		}

init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {		init(encryptionKey?: ?SubtleCrypto$JsonWebKey) {
this.status = databaseStatuses.initInProgress;		this.status = databaseStatuses.initInProgress;
this.worker = new SharedWorker(DATABASE_WORKER_PATH);		this.worker = new SharedWorker(DATABASE_WORKER_PATH);
▲ Show 20 Lines • Show All 77 Lines • Show Last 20 Lines