Page MenuHomePhabricator

[Flow202][lib][skip-ci] [16/23] Fix Flow issues in lib/selectors
ClosedPublic

Authored by ashoat on Nov 4 2023, 12:04 PM.
Tags
None
Referenced Files
F3388248: D9708.diff
Fri, Nov 29, 1:20 PM
Unknown Object (File)
Sun, Nov 24, 10:26 PM
Unknown Object (File)
Sat, Nov 23, 9:38 AM
Unknown Object (File)
Fri, Nov 8, 8:01 AM
Unknown Object (File)
Fri, Nov 8, 4:37 AM
Unknown Object (File)
Thu, Nov 7, 9:06 PM
Unknown Object (File)
Oct 27 2024, 10:49 PM
Unknown Object (File)
Oct 27 2024, 10:49 PM
Subscribers

Details

Summary

Flow was printing errors because it was having trouble deducing the types for these selectors. Adding typehints solved the errors.

The only exception is the case where I added a threadInfo.containingThreadID check. This was necessary because that value was used to index into a collection that didn't support null/undefined values.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9707

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Nov 4 2023, 12:32 PM
Harbormaster failed remote builds in B23750: Diff 32712!
This revision is now accepted and ready to land.Nov 6 2023, 4:53 AM
ashoat retitled this revision from [Flow202][lib] [16/23] Fix Flow issues in lib/selectors to [Flow202][lib][skip-ci] [16/23] Fix Flow issues in lib/selectors.Nov 19 2023, 3:04 PM
This revision was landed with ongoing or failed builds.Nov 27 2023, 3:25 PM
This revision was automatically updated to reflect the committed changes.