Differential D10012 Authored by ashoat on Nov 27 2023, 12:48 AM.
Details Summary We use this "unsafe" ReactNav container event to track internal ReactNav actions for our Redux devtools integration. NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.
Depends on D10011 Test Plan Confirm the Flow errors go away
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptNov 27 2023, 12:49 AM2023-11-27 00:49:00 (UTC-8) Harbormaster completed remote builds in B24453: Diff 33656.Nov 27 2023, 12:49 AM2023-11-27 00:49:01 (UTC-8) This revision is now accepted and ready to land.Nov 27 2023, 10:37 AM2023-11-27 10:37:10 (UTC-8) Closed by commit rCOMM74cae1da287f: [Flow202][native][skip-ci] [28/x] Type ReactNav __unsafe_action__ container… (authored by ashoat). · Explain WhyNov 27 2023, 3:28 PM2023-11-27 15:28:27 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 33656 |