Page MenuHomePhabricator

[Flow202][native][skip-ci] [15/x] Move unboundStyles to the top
ClosedPublic

Authored by ashoat on Nov 27 2023, 12:34 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 24 2024, 2:04 AM
Unknown Object (File)
Oct 27 2024, 5:32 PM
Unknown Object (File)
Oct 16 2024, 7:00 AM
Unknown Object (File)
Sep 29 2024, 12:22 AM
Unknown Object (File)
Sep 29 2024, 12:22 AM
Unknown Object (File)
Sep 29 2024, 12:21 AM
Unknown Object (File)
Sep 29 2024, 12:10 AM
Unknown Object (File)
Aug 28 2024, 6:29 AM
Subscribers
None

Details

Summary

Flow was printing errors like this:

Error ------------------------------------------------------------------------- account/logged-out-modal.react.js:144:19

Cannot use variable unboundStyles [1] because the declaration either comes later or was skipped.
[reference-before-declaration]

     141|   +loggedIn: boolean,
     142|   +dimensions: DerivedDimensionsInfo,
     143|   +splashStyle: ImageStyle,
     144|   +styles: typeof unboundStyles,
     145|   // Redux dispatch functions
     146|   +dispatch: Dispatch,
     147|   // Keyserver olm sessions functions
        :
 [1] 692| const unboundStyles = {

To address it I moved all of the unboundStyles definitions above their corresponding typeof invocations.

NOTE: CI will fail on this diff. I considered the possibility of fixing Flow errors BEFORE upgrading Flow, but it wasn't possible... in some cases, the fixes to support the new version of Flow caused errors in the old version. I could have hidden these type errors with $FlowFixMe lines and then later revert those, but that seemed like too much busy work.

Depends on D9998

Test Plan

Confirm the Flow errors go away

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable